Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error in conan remove when using -p without a pattern that matches packages #13622

Merged

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Apr 5, 2023

Changelog: Fix: Add error in conan remove when using --package-query without providing a pattern that matches packages.
Docs: Omit

Not sure about the readability of the error message, would appreciate suggestions to improve it

Closes #13595
(For real this time)

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the failing test was wrong, fix the test to removed the unused package_query

@memsharded memsharded merged commit 17ab8e1 into conan-io:release/2.0 Apr 5, 2023
@memsharded memsharded added this to the 2.0.4 milestone Apr 5, 2023
@AbrilRBS AbrilRBS deleted the rr/fix-remove-packages-p-query branch April 5, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] conan remove <ref> -p <query> removes all packages and recipe instead of packages matching query
2 participants