new build-order-prepare subcommand #13685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
Apr 13, 2023
AbrilRBS
reviewed
Apr 13, 2023
Comment on lines
+94
to
+95
| subparser.add_argument("ref", help="recipe to build") | ||
| subparser.add_argument("package_id", help="package to build") |
There was a problem hiding this comment.
Couldn't we put this two arguments together so that you need to pass pkg/1.0:abc123? Your way is more explicit which might avoid confusion though..
There was a problem hiding this comment.
Yes, that is doable, whatever UI the team prefers.
There was a problem hiding this comment.
Yes, I think I agree with adding the package_id in the reference too instead of a separate argument
czoido
reviewed
Apr 14, 2023
| @conan_subcommand(formatters={"text": cli_out_write}) | ||
| def graph_build_order_prepare(conan_api, parser, subparser, *args): | ||
| """ | ||
| Compute the build order of a dependency graph. |
czoido
reviewed
Apr 14, 2023
| @@ -83,6 +85,37 @@ def graph_build_order(conan_api, parser, subparser, *args): | |||
| return install_order_serialized | |||
|
|
|||
|
|
|||
| @conan_subcommand(formatters={"text": cli_out_write}) | |||
| def graph_build_order_prepare(conan_api, parser, subparser, *args): | |||
There was a problem hiding this comment.
I think that maybe the name of the subcommand it's not so intuitive, what about something like:
conan graph install-prepareconan graph install-config
Maybe more explicit like this?conan graph generate-install-args
|
Dropping this:
Continue in #13597 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: New
conan graph build-order-preparefor CI flows simplificationDocs: https://github.com/conan-io/docs/pull/XXXX