Improve conan inspect output, it now understands set_name/set_version
#13716
Conversation
…efault_options and options_description
conan/cli/commands/inspect.py
Outdated
| from conan.cli.formatters import default_json_formatter | ||
|
|
||
|
|
||
| def inspect_text_formatter(data): | ||
| for name, value in data.items(): | ||
| for name, value in sorted(data.items(), key=lambda x: x[0]): |
There was a problem hiding this comment.
why this lambda? Not very intuitive
There was a problem hiding this comment.
While playing with the output I realized it would be insertion-order dependant and implemented a sort on the items to have them show up alphabetically. Maybe we want to have a custom order and just have to be carefurl about when we insert the result in the serialization?
There was a problem hiding this comment.
Still not sure. sorted(mydict.items()) already sorts by the first element (key), no need for the lambda
AbrilRBS
changed the title
conan inspectconan inspect output, it now understands set_name/set_version
| if self.version is not None: | ||
| result["version"] = str(self.version) | ||
| if self.topics is not None: | ||
| result["topics"] = list(self.topics) |
There was a problem hiding this comment.
Not happy about this, but some tests were failing when calling graph create for json formatter (test/integration/command/create_test.py:475). I do wonder why now and not with the old changes the also has the topics returned
conans/model/conan_file.py
Outdated
| for a in ("name", "user", "channel", "url", "license", | ||
| "author", "description", "homepage", "build_policy", "upload_policy", | ||
| "revision_mode", "provides", "deprecated", "win_bash", "win_bash_run", | ||
| "default_options", "options_description", "generators", "requires"): |
There was a problem hiding this comment.
Serialization of the requires field is a bit uncertain how is being serialized, as it is a Python Requirements object?
Changelog: Feature: Improve
conan inspectoutput, it now understandsset_name/set_version.Docs: conan-io/docs#3204
conan inspectnow parses the conanfile and returns its serializationClose #13628