Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed default -v level #13839

Merged
merged 3 commits into from
May 8, 2023
Merged

Changed default -v level #13839

merged 3 commits into from
May 8, 2023

Conversation

franramirez688
Copy link
Contributor

Changelog: Feature: -v argument defaults to the VERBOSE level.
Docs: omit

@franramirez688 franramirez688 requested a review from memsharded May 8, 2023 10:29
@franramirez688 franramirez688 self-assigned this May 8, 2023
AbrilRBS
AbrilRBS approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What controls the default level now? _conan_output_level?

@franramirez688
Copy link
Contributor Author

What controls the default level now? _conan_output_level?

The logic is exactly the same right now, what am I missing?

memsharded
memsharded reviewed May 8, 2023
View reviewed changes
conan/api/output.py Outdated Show resolved Hide resolved
@franramirez688 franramirez688 requested a review from memsharded May 8, 2023 11:31
@franramirez688 franramirez688 mentioned this pull request May 8, 2023
Merged
@memsharded memsharded added this to the 2.0.5 milestone May 8, 2023
@AbrilRBS AbrilRBS merged commit 13a42b6 into conan-io:release/2.0 May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@franramirez688 franramirez688

Labels
None yet
Projects
None yet
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@franramirez688 @AbrilRBS @memsharded