fix 13899: lockfile usage with transitive tool-dependencies #13902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proper testcase(s) and review need to be performed by a conan expert. |
|
|
|
Any update when this will be merged? 1.60.0 is not useable without this fix. |
|
Adding tests in 8e25eb4 (checked that they fail in 1.60, fixed with this fix) |
AbrilRBS
approved these changes
May 29, 2023
czoido
approved these changes
May 30, 2023
czoido
pushed a commit
that referenced
this pull request
May 30, 2023
* fix 13899: lockfile usage with transitive tool-dependencies * add tests --------- Co-authored-by: memsharded <james@conan.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fix lockfile usage with transitive tool-dependencies.
Docs: Omit
Fixes: #13899
[bug] Some build requires cannot be found in lockfile with conan 1.60.0 anymore #13899
developbranch, documenting this one.