-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tool configuration to specify CMake executable path (#12701) #13940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Could you please add some unit test that will cover this new conf
functionality? One in the unittest
folder could be enough
If you want this functionality to be included in next 2.0.X releases, please target the PR to the release/2.0
branch, it can be added there, no risk.
Also, add a unit test for the new configuration item.
bf453d5
to
1141275
Compare
All right, I've re-targeted the PR to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The only remaining issue is that moving the branches targets for the PR created some confussion for the CLA-assistant. If it doesn't automatically resolve (sometimes after some time CLA-assistant is able to figure out the contributors correctly), it might need to close it and open a new PR, lets see how it goes.
Thanks again for your contribution.
Changelog: Feature: Add a
tools.cmake:cmake_program
configuration item to allow specifying the location of the desired CMake executable.Docs: conan-io/docs#3232
Fixes: #12701
develop
branch, documenting this one.