Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_requires shouldn't affect package_id #13966

Merged
merged 3 commits into from
May 25, 2023

Conversation

memsharded
Copy link
Member

Changelog: Bugfix: test_requires were affecting the package_id of consumers as regular requires, but they shouldn't.
Docs: Omit

Close #13965

@memsharded memsharded added this to the 2.0.6 milestone May 25, 2023
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nuce catch!

@czoido czoido merged commit 28d737c into conan-io:release/2.0 May 25, 2023
@memsharded memsharded deleted the fix/test_requires_package_id branch May 25, 2023 17:33
memsharded added a commit to memsharded/conan that referenced this pull request May 26, 2023
* test_requires shouldn't affect package_id

* test with transitive

* remove prints
memsharded added a commit that referenced this pull request Jun 2, 2023
* pkglist

* wip

* fix test

* changed PackageList approach to include multiple remotes

* fixes

* review

* wip

* Conan 2.0.6

* Fix format for id property in graph output json (#13964)

* convert to str

* franchus review

* test_requires shouldn't affect package_id (#13966)

* test_requires shouldn't affect package_id

* test with transitive

* remove prints

* [graph][json] Same json output for conan graph info, create, install and export-pkg (#13967)

* Ensuring the output for the rest of commands

* export-pkg too

* graph as first output level

* wip

* typo

* typos

* wip

* wip

* fixes

* review

* added download of pkg-list

* Update conan/cli/commands/download.py

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

* review

---------

Co-authored-by: czoido <mrgalleta@gmail.com>
Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
en-sc pushed a commit to en-sc/riscv-openocd that referenced this pull request Oct 19, 2023
Version 2.0.6 contains a critical bugfix, which influence binary
compatibility of openocd

See conan-io/conan#13966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check the interaction between package ids and test_requires
4 participants