Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make functional test not use mocks #13988

Merged
merged 1 commit into from
May 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 60 additions & 51 deletions conans/test/functional/toolchains/gnu/test_pkg_config.py
Original file line number Diff line number Diff line change
@@ -1,61 +1,70 @@
import os
import textwrap

import pytest

from conan.tools.gnu.pkgconfig import PkgConfig
from conans.errors import ConanException
from conans.model.build_info import CppInfo
from conans.test.utils.mocks import ConanFileMock
from conans.test.utils.test_files import temp_folder
from conans.util.files import save

libastral_pc = """
PC FILE EXAMPLE:

prefix=/usr/local
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: libastral
Description: Interface library for Astral data flows
Version: 6.6.6
Libs: -L${libdir}/libastral -lastral -lm -Wl,--whole-archive
Cflags: -I${includedir}/libastral -D_USE_LIBASTRAL
"""
from conans.test.utils.tools import TestClient


@pytest.mark.tool("pkg_config")
class TestPkgConfig:
""" This test uses the pkg_config in the system
"""
def test_negative(self):
conanfile = ConanFileMock()
pkg_config = PkgConfig(conanfile, 'libsomething_that_does_not_exist_in_the_world')
with pytest.raises(ConanException):
pkg_config.libs()
c = TestClient()
conanfile = textwrap.dedent("""
from conan import ConanFile
from conan.tools.gnu import PkgConfig

class Pkg(ConanFile):
def generate(self):
pkg_config = PkgConfig(self, "something_that_not_exist")
pkg_config.libs
""")
c.save({"conanfile.py": conanfile})
c.run("install .", assert_error=True)
assert "Package something_that_not_exist was not found" in c.out

def test_pc(self):
tmp_dir = temp_folder()
filename = os.path.join(tmp_dir, 'libastral.pc')
save(filename, libastral_pc)

conanfile = ConanFileMock()
pkg_config = PkgConfig(conanfile, "libastral", pkg_config_path=tmp_dir)

assert pkg_config.provides == "libastral = 6.6.6"
assert pkg_config.version == "6.6.6"
assert pkg_config.includedirs == ['/usr/local/include/libastral']
assert pkg_config.defines == ['_USE_LIBASTRAL']
assert pkg_config.libs == ['astral', 'm']
assert pkg_config.libdirs == ['/usr/local/lib/libastral']
assert pkg_config.linkflags == ['-Wl,--whole-archive']
assert pkg_config.variables['prefix'] == '/usr/local'

cpp_info = CppInfo()
pkg_config.fill_cpp_info(cpp_info, is_system=False, system_libs=["m"])

assert cpp_info.includedirs == ['/usr/local/include/libastral']
assert cpp_info.defines == ['_USE_LIBASTRAL']
assert cpp_info.libs == ['astral']
assert cpp_info.system_libs == ['m']
assert cpp_info.libdirs == ['/usr/local/lib/libastral']
assert cpp_info.sharedlinkflags == ['-Wl,--whole-archive']
c = TestClient()
conanfile = textwrap.dedent("""
from conan import ConanFile
from conan.tools.gnu import PkgConfig
from conans.model.build_info import CppInfo

class Pkg(ConanFile):
def generate(self):
pkg_config = PkgConfig(self, "libastral", pkg_config_path=".")
self.output.info(f"PROVIDES: {pkg_config.provides}")
self.output.info(f"VERSION: {pkg_config.version}")
self.output.info(f"VARIABLES: {pkg_config.variables['prefix']}")

cpp_info = CppInfo()
pkg_config.fill_cpp_info(cpp_info, is_system=False, system_libs=["m"])

assert cpp_info.includedirs == ['/usr/local/include/libastral']
assert cpp_info.defines == ['_USE_LIBASTRAL']
assert cpp_info.libs == ['astral']
assert cpp_info.system_libs == ['m']
assert cpp_info.libdirs == ['/usr/local/lib/libastral']
assert cpp_info.sharedlinkflags == ['-Wl,--whole-archive']
""")
libastral_pc = textwrap.dedent("""\
PC FILE EXAMPLE:

prefix=/usr/local
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: libastral
Description: Interface library for Astral data flows
Version: 6.6.6
Libs: -L${libdir}/libastral -lastral -lm -Wl,--whole-archive
Cflags: -I${includedir}/libastral -D_USE_LIBASTRAL
""")
c.save({"conanfile.py": conanfile,
"libastral.pc": libastral_pc})
c.run("install .")
assert "conanfile.py: PROVIDES: libastral = 6.6.6" in c.out
assert "conanfile.py: VERSION: 6.6.6" in c.out
assert "conanfile.py: VARIABLES: /usr/local" in c.out
7 changes: 2 additions & 5 deletions conans/test/utils/mocks.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import os
from collections import namedtuple
from io import StringIO


Expand Down Expand Up @@ -103,8 +102,8 @@ def run(self, *args, **kwargs):

class ConanFileMock(ConanFile):

def __init__(self, shared=None):
self.display_name = ""
def __init__(self, display_name=""):
self.display_name = display_name
self._conan_node = None
self.command = None
self._commands = []
Expand All @@ -113,8 +112,6 @@ def __init__(self, shared=None):
self.settings_build = MockSettings({"os": "Linux", "arch": "x86_64"})
self.settings_target = None
self.options = Options()
if shared is not None:
self.options = namedtuple("options", "shared")(shared)
self.generators = []
self.captured_env = {}
self.folders = Folders()
Expand Down