Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conan version as separated command #13999

Merged
merged 6 commits into from
May 31, 2023
Merged

Add conan version as separated command #13999

merged 6 commits into from
May 31, 2023

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented May 30, 2023 •
edited by czoido
Loading

Changelog: Feature: Add new command conan version to format the output.
Docs: conan-io/docs#3243

The --version option stays as usual, but conan version offer format output.

closes #13952

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@uilianries
Add conan version command
05094d8 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries requested a review from memsharded May 30, 2023 13:57
memsharded
memsharded reviewed May 30, 2023
View reviewed changes
conan/cli/commands/version.py Outdated Show resolved Hide resolved
conan/cli/commands/version.py Outdated Show resolved Hide resolved
conans/test/integration/command_v2/test_version.py Outdated Show resolved Hide resolved
@uilianries
Print python version as well
dfb5476 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
memsharded
memsharded reviewed May 30, 2023
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Check failing tests, but almost there.

conan/cli/commands/version.py Outdated Show resolved Hide resolved
AbrilRBS
AbrilRBS approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than @memsharded's comments

uilianries added 4 commits May 31, 2023 09:51
@uilianries
don't reinvent the wheel - print_serial
07a12ad 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
adjust tests
edad28a 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
strip new lines
b2aa81a 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
better format for testing conan version
24e82ab 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries mentioned this pull request May 31, 2023
Merged
@memsharded memsharded merged commit e1f4c62 into conan-io:release/2.0 May 31, 2023
@memsharded memsharded added this to the 2.0.7 milestone May 31, 2023
@memsharded memsharded mentioned this pull request May 31, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
2.0.7
Development

Successfully merging this pull request may close these issues.

[feature] Include conan --version command in conan --help text
3 participants
@uilianries @AbrilRBS @memsharded