Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload --dry-run and tests fixes #14002

Merged
merged 5 commits into from
Jun 13, 2023

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented May 30, 2023

Changelog: Feature: Add conan upload --dry-run equivalent to 1.X conan upload --skip-upload.
Docs: conan-io/docs#3274

Also, recover or remove some xfailed tests (the PR started there, then realized that the --dry-run feature was not there, and I recall it being used by some users in 1.X

@memsharded memsharded added this to the 2.0.7 milestone May 30, 2023
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any other command where this functionallity might be missing?

@memsharded
Copy link
Member Author

Is there any other command where this functionallity might be missing?

This was the only one in Conan 1.X (btw, I am open to keep the --skip-upload 1.X syntax).
One use case was doing all the heavy compressions and integrity checks in one pass, then uploading all, so the actual upload was faster (compression can take a lot of time for large packages), improving a bit the atomicity of the upload. Also, the idea is that this will also support the upload via Artifactory API, but we can discuss this, if premature I can remove it, it was not the intent of this PR, but to fix tests.

I am not sure other commands do need it. For download/remove we already have the package-lists feature, that lists you the things that will be removed/downloaded.

@AbrilRBS
Copy link
Member

AbrilRBS commented Jun 2, 2023

Thanks for the extra context, quite helpful :)

btw, I am open to keep the --skip-upload 1.X syntax

I like the --dry-run syntax better

@memsharded memsharded self-assigned this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants