Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git.clone change folder to target one #14063

Merged
merged 4 commits into from
Jun 14, 2023
Merged

Git.clone change folder to target one #14063

merged 4 commits into from
Jun 14, 2023

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jun 9, 2023 •
edited
Loading

Changelog: Fix: Allow spaces in path in Git helper.
Docs: conan-io/docs#3271

Close #14058

@memsharded memsharded added this to the 2.0.7 milestone Jun 9, 2023
@memsharded memsharded marked this pull request as ready for review June 14, 2023 11:55
@memsharded memsharded self-assigned this Jun 14, 2023
@memsharded memsharded requested a review from AbrilRBS June 14, 2023 11:56
AbrilRBS
AbrilRBS approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One minor comment about the test

conans/test/functional/tools/scm/test_git.py Outdated Show resolved Hide resolved
@memsharded memsharded merged commit 908fc4f into conan-io:release/2.0 Jun 14, 2023
@memsharded memsharded deleted the feature/git_clone_change_folder branch June 14, 2023 13:09
This was referenced Jun 14, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.0.7
Development

Successfully merging this pull request may close these issues.

[bug] Git.checkout() with a target folder doesn't work with the remaining Git functions
2 participants
@memsharded @AbrilRBS