Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default build profile is no longer none #14075

Merged
merged 1 commit into from
Jun 12, 2023
Merged

default build profile is no longer none #14075

merged 1 commit into from
Jun 12, 2023

Conversation

prince-chrismc
Copy link
Contributor

@prince-chrismc prince-chrismc commented Jun 12, 2023

Changelog: Fix: Fix description for the conf entry for default build profile used.
Docs: conan-io/docs#3252

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Saw this while poking around 😄 seems like it was missed in the migration

default_profile = cache.new_config.get("core:default_build_profile", default=DEFAULT_PROFILE_NAME)

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello stranger 🙈 Good catch!
Thanks a lot for your contribution, I have submitted conan-io/docs#3252 to the docs to keep them in sync :)

@memsharded memsharded merged commit cb0d68f into conan-io:release/2.0 Jun 12, 2023
@memsharded memsharded added this to the 2.0.7 milestone Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants