make CppInfo an importable tool #14101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcar87
approved these changes
Jun 16, 2023
memsharded
commented
Jun 18, 2023
| cpp_info.save(p) | ||
|
|
||
| def package_info(self): | ||
| cpp_info = CppInfo(self).load("cpp_info.json") |
There was a problem hiding this comment.
This test shows that the interface cannot be a class/static method like CppInfo.load() as we typically do in the codebase, but it is loading on an already existing object (overwriting it)
czoido
approved these changes
Jun 19, 2023
franramirez688
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Make
CppInfoa public, documented, importable tool for generators that need to aggregate them.Docs: conan-io/docs#3268
Close #13758 (#13758 (comment)), but:
Probably better wait. Conan 1.X uses
NewCppInfoinstead, so it is going to be challenging. Lets move forward with 2.0 only, and see what happens and user feedback.