Allow upload --list to accept empty lists
#14254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AbrilRBS
reviewed
Jul 8, 2023
memsharded
approved these changes
Jul 9, 2023
AbrilRBS
reviewed
Jul 9, 2023
AbrilRBS
approved these changes
Jul 9, 2023
|
Thanks a lot for taking the time to contribute this feature, we really appreciate it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Using
uploadwith the--listargument now permits empty recipe lists.Docs: Omit
My approach was to still error on recipe patterns that are empty when not using a list. Therefore, I added two tests -- one to ensure that passing a
--listargument that had no recipes in it was valid, and the second to ensure passing a non-matching pattern still errored with the "No recipes found matching pattern" message.Fixes #14203