Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed pyyaml installation due to cython update #14317

Closed
wants to merge 3 commits into from
Closed

fixed pyyaml installation due to cython update #14317

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ae6882
Conan 1.59
czoido Feb 16, 2023
860b89a
fixed pyyaml installation due to cython update
piri-nyan Jul 18, 2023
95446a1
moving base to 1.60
piri-nyan Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conans/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@
SERVER_CAPABILITIES = [COMPLEX_SEARCH_CAPABILITY, REVISIONS] # Server is always with revisions
DEFAULT_REVISION_V1 = "0"

__version__ = '1.59.0-dev'
__version__ = '1.59.0'
2 changes: 1 addition & 1 deletion conans/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
requests>=2.25, <3.0.0
urllib3>=1.26.6, <1.27
colorama>=0.3.3, <0.5.0
PyYAML>=3.11, <=6.0
PyYAML==6.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned of too restrictive constraint would break some special users that might workaround the cython issue, use older PyYAML version in some special distros or whatever. I have done #14323 to propose allowing future PyYAML patches too, I think it should be pretty safe and better in general than a strong pinning to 6.0.1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okiii, we can decline this PR then, i guess we'll have to wait for PyYAML to fix their builds 😞

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to you for raising the issue and contributing a fix!

i guess we'll have to wait for PyYAML to fix their builds

But #14323 will also fix immediately the issue in Conan 1.60.2, won't it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will, i don't question that, i just hope that PyYAML will resolve issues with their builds. Because if they wont, this issue will come up again sometime :)

patch-ng>=1.17.4, <1.18
fasteners>=0.14.1
six>=1.10.0,<=1.16.0
Expand Down