[Bazel][1.x][Part 2]: BazelDeps refactor #14959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franramirez688
force-pushed
the
frm/bazeldeps_refactor_1x
branch
from
6933810 to
c20b270
Compare
franramirez688
force-pushed
the
frm/bazeldeps_refactor_1x
branch
from
c20b270 to
27ae3b9
Compare
franramirez688
force-pushed
the
frm/bazeldeps_refactor_1x
branch
from
ebc9364 to
947b181
Compare
franramirez688
force-pushed
the
frm/bazeldeps_refactor_1x
branch
from
15ebb15 to
fd13c23
Compare
franramirez688
commented
Oct 30, 2023
|
|
||
|
|
||
| @pytest.fixture(scope="module") | ||
| def client_lib(bazelrc): |
There was a problem hiding this comment.
Removed because it's enough tested by the next test test_transitive_libs_consuming.
memsharded
reviewed
Oct 30, 2023
czoido
reviewed
Nov 2, 2023
czoido
reviewed
Nov 2, 2023
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
SSE4
reviewed
Nov 2, 2023
SSE4
reviewed
Nov 2, 2023
SSE4
reviewed
Nov 2, 2023
SSE4
reviewed
Nov 2, 2023
| std::cout << "openssl() First define " << MY_DEFINE << " and other define " << MY_OTHER_DEFINE << "\\n"; | ||
| zlib(); | ||
| // This comes from the systemlibs declared in the zlib | ||
| sqrt(25); |
There was a problem hiding this comment.
not okay to ignore return value (compiler may optimize out if there are no side-effects)
SSE4
reviewed
Nov 2, 2023
SSE4
reviewed
Nov 2, 2023
SSE4
reviewed
Nov 2, 2023
czoido
reviewed
Nov 3, 2023
czoido
reviewed
Nov 6, 2023
memsharded
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: BazelDeps global refactor. Adding each component as an isolated target, better requirements management (including requirements coming from build-context), adding C/C++ flags, etc.
Changelog: Feature: BazelDeps works fine in editable mode.
Changelog: Feature: Added
bazel_target_nameandbazel_repository_nameproperties.Changelog: Feature: Added mechanism to consume shared/static libraries for
bazel_libtemplate in all the platforms.Docs: conan-io/docs#3457
Closes: #13197 #13234 #12786
Depends on #14958
Summary:
bazel_layoutto be able to work in editable mode.coptsoptionfilegroupsfor binary foldersbazel_libgenerates projects that are able to compile as shared/static libraries.