Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x][bugfix] Skipped binaries do not appear on requires #15320

Merged

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Dec 21, 2023

Changelog: Bugfix: Non-visible transitive dependencies are not included in the requires (PkgConfigDeps).
Changelog: Bugfix: from_old_cppinfo helper checks if the old cpp_info is not None before merging.
Docs: omit
Closes: #15311

@franramirez688 franramirez688 added this to the 1.63 milestone Dec 21, 2023
@franramirez688 franramirez688 changed the title [1.x][bugfix] NewCppInfo avoid merging None values [1.x][bugfix] Skipped binaries do not appear on requires Dec 21, 2023
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit concerned about this fix, but it looks correct, so lets try it.

@franramirez688
Copy link
Contributor Author

I am a bit concerned about this fix, but it looks correct, so let's try it.

Yes 😞 Let's remember that we don't need any of these changes in the Conan 2.x branches, only the test hopefully.

@franramirez688 franramirez688 merged commit 787eb23 into conan-io:develop Dec 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants