-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-poc for cppstd compatibility exact #15348
Merged
memsharded
merged 8 commits into
conan-io:develop2
from
memsharded:feature/compatibility_cppstd_exact
Jan 22, 2024
Merged
test-poc for cppstd compatibility exact #15348
memsharded
merged 8 commits into
conan-io:develop2
from
memsharded:feature/compatibility_cppstd_exact
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
commented
Jan 2, 2024
conans/client/graph/compatibility.py
Outdated
@@ -29,7 +29,8 @@ def compatibility(conanfile): | |||
|
|||
def cppstd_compat(conanfile): | |||
# It will try to find packages with all the cppstd versions | |||
|
|||
if not getattr(conanfile, "compatibility_cppstd", True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets explore the conf
mechanism instead of attributes:
- With intermediate priorities, soft and hard overwritten by user profiles
memsharded
commented
Jan 2, 2024
memsharded
commented
Jan 4, 2024
1 task
AbrilRBS
approved these changes
Jan 19, 2024
czoido
approved these changes
Jan 22, 2024
jcar87
approved these changes
Jan 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add
extension_properties
attribute to pass information to extensions from recipes.Changelog: Feature: Implement
compatibility_cppstd
inextension_properties
for thecompatibility.py
plugin to disable fallback to other cppstd for the recipe.Docs: conan-io/docs#3549
Close #15347