Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deactivate_conanvcvars file with message #15557

Conversation

juansblanco
Copy link
Contributor

@juansblanco juansblanco commented Jan 29, 2024

Changelog: Feature: Display message when calling deactivate_conanvcvars.
Docs: Omit

Issue: Running the deactivate_conanbuild script after activating a environment with vcvars gave an error because the deactivate_conanvcvars file didn't exist.
To fix this the file is now created and it displays a message saying conanvcvars env can't be deactivated when called.

@juansblanco juansblanco marked this pull request as ready for review January 30, 2024 11:40
@juansblanco juansblanco added this to the 2.1 milestone Jan 30, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Minor nitpicks

conan/tools/microsoft/visual.py Outdated Show resolved Hide resolved
@AbrilRBS AbrilRBS merged commit 748b417 into conan-io:develop2 Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants