Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to unhide git url #16038

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Allow to unhide git url #16038

merged 4 commits into from
Apr 8, 2024

Conversation

shoeffner
Copy link
Contributor

@shoeffner shoeffner commented Apr 7, 2024 •
edited by czoido
Loading

Changelog: Feature: Add an argument hide_url to Git operations to allow logging of the repository URL. By default, URLs will stay <hidden>, but users may opt-out of this.
Docs: Omit

Close #15684

  • Refer to the issue that supports this Pull Request: [feature] The git clone URL is no longer logged. #15684
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@AbrilRBS AbrilRBS self-assigned this Apr 7, 2024
@memsharded memsharded added this to the 2.3.0 milestone Apr 7, 2024
@shoeffner
Copy link
Contributor Author

I see you added a docs TODO, what do you think should I add to the docs?

@AbrilRBS
Copy link
Member

AbrilRBS commented Apr 8, 2024 •
edited
Loading

Hi! Thanks a lot for taking the time to implement this, it's really appreciated :)

The docs will automatically add the new argument, we just want to check if there's a place where it makes sense to add a note about this, will get back to you on that, thanks a lot for the offer!

AbrilRBS
AbrilRBS approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a minor test change to somewhat speed them up!

conans/test/functional/tools/scm/test_git.py Outdated Show resolved Hide resolved
conans/test/functional/tools/scm/test_git.py Outdated Show resolved Hide resolved
memsharded
memsharded approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@shoeffner
Copy link
Contributor Author

Thanks, didn't know about light!

@AbrilRBS AbrilRBS merged commit 38188da into conan-io:develop2 Apr 8, 2024
2 checks passed
@shoeffner shoeffner deleted the unhide-git-url branch April 8, 2024 22:10
memsharded pushed a commit to memsharded/conan that referenced this pull request Apr 9, 2024
@shoeffner @AbrilRBS @memsharded
Allow to unhide git url (conan-io#16038)
ce4f5df 
* Add hide_url tests for git scm tool

* Add hide_url flag to clone and fetch_commit.

Resolves conan-io#15684

* Update conans/test/functional/tools/scm/test_git.py

* Update conans/test/functional/tools/scm/test_git.py

---------

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
memsharded pushed a commit to memsharded/conan that referenced this pull request Apr 10, 2024
@shoeffner @AbrilRBS @memsharded
Allow to unhide git url (conan-io#16038)
6fe16fa 
* Add hide_url tests for git scm tool

* Add hide_url flag to clone and fetch_commit.

Resolves conan-io#15684

* Update conans/test/functional/tools/scm/test_git.py

* Update conans/test/functional/tools/scm/test_git.py

---------

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
memsharded added a commit that referenced this pull request Apr 11, 2024
@memsharded @franramirez688
@shoeffner @AbrilRBS
Internal refactor for readability of CMakeDeps (#16040)
ad0b39c 
* cmake deps internal refactor for readability

* fix

* fix

* fix

* fix

* fix

* copy only if different (#16031)

* allow conf in exports-sources and export (#16034)

* refactor apple_min_version_flag() (#16017)

* refactor apple_min_version_flag()

* Refactored all the apple module and where it was being used (AutotoolsToolchain and MesonToolchain for now)

* Fixed bad return

* Fixing tests

* Keeping legacy behavior in apple_min_version_flag function

* Preventing possible breaking change

---------

Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com>

* Allow to unhide git url (#16038)

* Add hide_url tests for git scm tool

* Add hide_url flag to clone and fetch_commit.

Resolves #15684

* Update conans/test/functional/tools/scm/test_git.py

* Update conans/test/functional/tools/scm/test_git.py

---------

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* remove repeated non-running test (#16053)

* refactor transitive_requires

---------

Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com>
Co-authored-by: Sebastian Höffner <info@sebastian-hoeffner.de>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
czoido pushed a commit that referenced this pull request Jun 4, 2024
@memsharded @ErniGH
@franramirez688 @shoeffner @AbrilRBS
Feature/language (#16028)
b88c8bb 
* wip

* wip

* wip

* Test for BazelDeps in the build context (#16025)

* feat add test to bazeldeps

* Fixed several bugs. Improved tests coverage

* Reverted

* Better name

---------

Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com>

* copy only if different (#16031)

* allow conf in exports-sources and export (#16034)

* refactor apple_min_version_flag() (#16017)

* refactor apple_min_version_flag()

* Refactored all the apple module and where it was being used (AutotoolsToolchain and MesonToolchain for now)

* Fixed bad return

* Fixing tests

* Keeping legacy behavior in apple_min_version_flag function

* Preventing possible breaking change

---------

Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com>

* Allow to unhide git url (#16038)

* Add hide_url tests for git scm tool

* Add hide_url flag to clone and fetch_commit.

Resolves #15684

* Update conans/test/functional/tools/scm/test_git.py

* Update conans/test/functional/tools/scm/test_git.py

---------

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* wip

* wip

* wip

* fix

* Update conan/tools/build/cstd.py

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update conan/tools/build/cstd.py

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update conan/tools/build/cstd.py

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

---------

Co-authored-by: Ernesto de Gracia Herranz <vivalaburocracia@hotmail.com>
Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com>
Co-authored-by: Sebastian Höffner <info@sebastian-hoeffner.de>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

[feature] The git clone URL is no longer logged.
3 participants
@shoeffner @AbrilRBS @memsharded