Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmakedeps: clarify debug message #17453

Merged
merged 1 commit into from
Dec 11, 2024
Merged

cmakedeps: clarify debug message #17453

merged 1 commit into from
Dec 11, 2024

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Dec 11, 2024 •
edited by czoido
Loading

Changelog: Fix: Clarify debug message in CMakeDeps.
Docs: Omit

  • Do not print a message if the import library and the dll have different names - in the vast majority of cases, CMake does not need to locate the DLL (only the import library is used at link time, and that must be correctly reflected in the package info)
  • Leave the message in DEBUG

This will reduce user confusion, and will be addressed with the new cpp_info model and the new CMakeDeps, where we can specify both the "location" (the DLL), and "link_location" for the import library.

@jcar87 jcar87 requested a review from memsharded December 11, 2024 17:08
@memsharded memsharded added this to the 2.11.0 milestone Dec 11, 2024
@memsharded memsharded self-assigned this Dec 11, 2024
@memsharded memsharded merged commit 91f743b into conan-io:develop2 Dec 11, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jcar87 @memsharded