Client with apiv2 (transfers in one step) #3442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
lasote
changed the title
memsharded
reviewed
Aug 30, 2018
danimtb
approved these changes
Sep 4, 2018
|
Pending:
|
|
Please, review again @memsharded
|
memsharded
approved these changes
Sep 13, 2018
| @@ -17,13 +17,13 @@ def attach_to(self, app): | |||
| @app.route(r.package, method=["GET"]) | |||
| @app.route(r.package_recipe_revision, method=["GET"]) | |||
| @app.route(r.package_revision, method=["GET"]) | |||
| def get_package_snapshot(name, version, username, channel, package_id, auth_user, | |||
| revision=None, p_revision=None): | |||
| def get_package_file_list(name, version, username, channel, package_id, auth_user, | |||
There was a problem hiding this comment.
Maybe convert it to a dict {file: {} }, to be extensible for the future. Can be {file: None} now, but that it will understand in the future:
{file = {size=12355, md5=012312312, ...},
file2 = {....}
memsharded
approved these changes
Sep 14, 2018
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
* Failing hard * Fixed v2 without revisions * Runner equal * typo * typo * Fixing test apiv2 * Fix test * Merged with develop * fixed jenkins conf * Renamed method * Prepared to work easier with revision and speculative metadata for files introduced in apiv2 * Fixing managing dict snapshot * Force CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed that our Downloader class follows correctly the 302 downloads redirects.
Changelog: Feature: Experimental and initial support for the REST apiv2 that will allow transfers in one step and revisions in the future.