Handle old versions (<1.8) of SVN #3757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
danimtb
previously approved these changes
Oct 16, 2018
jgsogo
dismissed
danimtb’s stale review
Incoming changes related to svn1.7, I'll ping you when it is ready to review again.
jgsogo
changed the title
|
Why not using XML for any SVN version to avoid having a double logic? |
|
|
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
* Use XML instead of --show-item if SVN version is less than 1.10 * Issue/svn1.7 (conan-io#4) * do not use --show-item for SVN under API change method * handle relative-url for svn <= 1.7 * SVN::is_pristine always return False for old svns * skip pristine tests for old svn * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Use XML output to retrieve information from SVN command line if its client version is less than 1.8 (command
--show-itemis not available).Changelog: Fix: SVN v1.7 does not have
-rargument insvn status, so functionalitySVN::is_pristinewon't be available.Here it is a PR to handle interface changes (detected up to now) between SVN 1.7.x and newer versions:
It should work for the use-cases reported up to now, but new issues will raise and we are not running CI tests with old SVN versions so we may break something in the future 😰