Evaluate always SCM attribute before exporting the recipe #4088
Conversation
ghost
assigned
|
|
||
| def get_commit(): | ||
| here = os.path.dirname(__file__) | ||
| here = os.getcwd() |
There was a problem hiding this comment.
It is not exactly the same... as a test (someone can look at it as an example) I prefer the previous behavior.
There was a problem hiding this comment.
With __file__ it fails. The file of the python require is located in a different place than the repo
| content = load(exported_conanfile) | ||
| self.assertIn(commit, content) | ||
| # Check that everything works and is usable |
There was a problem hiding this comment.
🤔 I will remove these lines because they are related to python_requires machinery, not to the replacement of the SCM information. I know it is the reason why my previous test was wrong, but now that it is ok these lines are only adding more time to the test suite. If not, can they be conditionally included to the slow attribute tag?
|
@lasote, do you think we need to write an example using this? I don't think so, it is expected behavior, just the combination of py_req and the early resolution of SCM |
|
Updated with a link to the docs |
Evaluate always SCM attribute before exporting the recipe
Changelog: Fix: Evaluate always SCM attribute before exporting the recipe
Docs: conan-io/docs#981
--- Edited by @lasote ---
If the SCM attributes rely on data/status of the working copy we need to evaluate the SCM attributes there. It happens with the
autokeywords, but it can happen with many other functions:All those data/status won't be available in the
exportedfolder of the cache.