Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'conans.CMake' a class again #7200

Merged
merged 3 commits into from
Jun 16, 2020

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Jun 15, 2020

Changelog: omit
Docs: omit

Fix #7196
Closes #7198

Implements a factory-like method using class __new__ function... just because Conan 2.0 will remove this trick

image

#tags: slow

@jgsogo jgsogo added this to the 1.26.1 milestone Jun 15, 2020
@jgsogo
Copy link
Contributor Author

jgsogo commented Jun 15, 2020

CI broken, +info: pypa/setuptools#2196 (waiting fix pypa/setuptools#2195)

@TheQwertiest
Copy link
Contributor

FYI: setup_tools fix is merged.

@jgsogo jgsogo requested a review from czoido June 16, 2020 12:12
@memsharded memsharded merged commit 970b960 into conan-io:release/1.26 Jun 16, 2020
@jgsogo jgsogo deleted the magic/cmake-build_helper branch June 17, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants