-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[poc][wip] Cache in local Artifactory everything that is downloaded by Conan #8110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. A few ideas:
The DownloadCache caches every file, the conanfile.py, conanmanifest.txt,... Here we probably want to cache only 3rdparty files:
yes, I think this backup should only cache things outside the Conan remotes, it doesn't make sense to cache thing from Conan repos. To think: What happen with "git clone" source retrieval that is not a download?
can we filter them using the URLs in the remote.json (maybe only v2)?
Yes, I think this is the way to go. No need v2 only, this feature will be new and experimental, so it can have implemented.
activate some flag before running certain methods to enable/disable this cache?
I would prefer the cache to filter based on origins if possible, instead of methods.
Do we want to provide some organization inside the generic repo or everything inside one folder?
I would say it should be a hash based storage, no organization.
Lets do some brainstorming about this, this was a good kick off!
conans/client/conf/__init__.py
Outdated
@@ -445,6 +445,14 @@ def download_cache(self): | |||
except ConanException: | |||
return None | |||
|
|||
@property | |||
def artifactory_cache(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better avoid the "cache" term, and call it something like "sources backup"
|
That is true, it is possible, but I am not aware of any server implementation right now that uses different URLs for the downloads, so it could be a good enough assumption. I am fine with providing this for revisions V2 only.
Yes, agree it can wait, it is just something to think at some point. |
This PR needs to be implemented on top of #8116 |
Superseded by #8211 |
Changelog: (Feature | Fix | Bugfix): Describe here your pull request
Docs: https://github.com/conan-io/docs/pull/XXXX
This is just to start talking about it and realize about different needs
The DownloadCache caches every file, the
conanfile.py
,conanmanifest.txt
,... Here we probably want to cache only 3rdparty files:remote.json
(maybe only v2)?Refactor before? Chain download classes?