possible fix to cmake.install() failing in test_package #8117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uilianries
reviewed
Dec 4, 2020
| @@ -36,7 +36,8 @@ def install_build_and_test(app, conanfile_abs_path, reference, graph_info, | |||
| manifest_interactive=manifest_interactive, | |||
| keep_build=keep_build, | |||
| recorder=recorder) | |||
| cmd_build(app, conanfile_abs_path, base_folder, test_build_folder, package_folder=None, | |||
| cmd_build(app, conanfile_abs_path, base_folder, test_build_folder, | |||
| package_folder=os.path.join(test_build_folder, "package"), | |||
There was a problem hiding this comment.
I would use conans.paths.PACKAGES_FOLDER instead:
from conans.paths import PACKAGES_FOLDER
...
cmd_build(app, conanfile_abs_path, base_folder, test_build_folder,
package_folder=os.path.join(test_build_folder, PACKAGES_FOLDER),There was a problem hiding this comment.
I think it is better to leave it explicit and independent, that is an internal path definition for the Conan cache. We might want to change it anytime, to something like "pkg", but we don't want to break what happens in user space.
uilianries
approved these changes
Dec 4, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Define
package_folderin thetest_packagefolder (defaulting to "package"), so the test recipe can executecmake.install()in itsbuild()method.Docs: Omit
Close #8080