Skip to content

- add docs for compilervars #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2020
Merged

- add docs for compilervars #1716

merged 3 commits into from
Jun 3, 2020

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented May 25, 2020 •
edited by jgsogo
Loading

@SSE4 SSE4 mentioned this pull request May 25, 2020
Merged
5 tasks
@SSE4 SSE4 force-pushed the compilervars branch 2 times, most recently from 404b861 to 9dced4e Compare May 25, 2020 16:40
@SSE4
- add docs for compilervars
5a16cba 
Signed-off-by: SSE4 <tomskside@gmail.com>
@jgsogo jgsogo added this to the 1.26 milestone Jun 1, 2020
jgsogo
jgsogo suggested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need another PR for the Conan client, these tools should accept the conanfile as the first argument.

@SSE4 SSE4 mentioned this pull request Jun 2, 2020
Merged
5 tasks
jgsogo
jgsogo suggested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR merged to Conan, need to document here the new signature

@jgsogo jgsogo merged commit 25b3025 into conan-io:develop Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

@danimtb danimtb danimtb approved these changes

Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.
3 participants
@SSE4 @jgsogo @danimtb