Skip to content

Clarify CMakeToolchain User presets documentation #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Jun 15, 2022

I think the documentation was correct before (and conan-io/conan#11452 simply fixes the bug where it was not following the documentation).

This PR just tries to clarify the behaviour of that file, a separate more elaborate note about how it will not be generated, and some general fixes for grammar consistency.

I've removed the mention to conanfile.generators_folder from that particular section, but I think that attribute affects the other files generated as well, so I felt it was odd only mentioning there. Will raise a separate PR to document it in the conanfile reference.

@jcar87 jcar87 requested review from lasote and czoido June 15, 2022 14:21
@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants