win_bash_run #2803
Merged
win_bash_run #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSE4
reviewed
Nov 4, 2022
|
|
||
| Available since: `1.54.0 <https://github.com/conan-io/conan/releases/tag/1.54.0>`_ | ||
|
|
||
| When ``True`` it enables running commands in the ``"run"`` scope, to run them inside a bash shell. |
There was a problem hiding this comment.
how do I enable it for an another scope?
There was a problem hiding this comment.
win_bash is that is used for the other scope ("build")
There was a problem hiding this comment.
I think that's not completely clear, maybe we can add some clarification on that for win_bash and maybe adding here something like this is the equivalent of win_bash for the run scope ?
SSE4
reviewed
Nov 4, 2022
Co-authored-by: SSE4 <tomskside@gmail.com>
czoido
reviewed
Nov 7, 2022
| @@ -949,8 +949,12 @@ You need to configure how to run the commands with two config variables: | |||
|
|
|||
czoido
reviewed
Nov 7, 2022
Comment on lines
954
to
+957
| Any command run with ``self.run``, if ``self.win_bash == True`` will run the command inside the specified shell. | ||
| Any command run with ``self.run(..., scope="run")`` if ``self.win_bash_run == True`` will run that command inside the shell. | ||
| In both cases running explicitly in the bash shell only happens if ``tools.microsoft.bash:active`` is not True, because | ||
| when it is True, it means that Conan is already running inside the shell. |
There was a problem hiding this comment.
For me this part reads a bit confusing, maybe illustrating with what Conan calls for each case or some example would make this part a bit more clear?
czoido
added a commit
to czoido/docs
that referenced
this pull request
Nov 8, 2022
franramirez688
added a commit
that referenced
this pull request
Nov 10, 2022
* add #2758 * add tools.scm * take #2800 and some fixes * add anchor to unix_path * take #2802 * take part of #2803 * take #2806 * Update reference/tools/cmake/cmaketoolchain.rst Co-authored-by: Francisco Ramírez <franchuti688@gmail.com> * Update reference/tools/cmake/cmaketoolchain.rst Co-authored-by: Francisco Ramírez <franchuti688@gmail.com> Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.