Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command conan remote #3031

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Fix command conan remote #3031

merged 3 commits into from
Feb 27, 2023

Conversation

Kasurus
Copy link
Contributor

@Kasurus Kasurus commented Feb 27, 2023

Closes #3027

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

AbrilRBS
AbrilRBS approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kasurus! Thank you so much for taking the time to open the PR fixing the issues, we really appreciate it :)
This changes look great, I must somehow have missed this command in #2999, so it's great to have it fixed now

@memsharded memsharded added this to the 2 milestone Feb 27, 2023
@memsharded memsharded merged commit 876ab64 into conan-io:develop2 Feb 27, 2023
@Kasurus Kasurus deleted the fix-command-conan-remote branch February 27, 2023 22:32
czoido added a commit that referenced this pull request Mar 3, 2023
@czoido @Kasurus
@AbrilRBS @CaiJingLong
Release/2.0.1 docs (#3051)
618f06e 
* Fix command conan remote (#3031)

* Fix conan remote add -h content

* Fix indentation

* Change 'optional arguments' to 'options'

Makes it identical to the actual command line output.

* Add info on .conanignore (#3036)

* Add info on .conanignore

* Add missing point

* Update conan config install documentation (#3035)

* Fix conan remote auth help typo (#3039)

* Fix conan remote auth help typo

* Fix whitespace issue

* fix typo for import syntax (#3024)

* Update tools.rst (#3047)

Fix typo

* Change documentation from conan-io/conan#13211 (#3046)

* add docs (#3049)

* remove from docs (#3050)

* 2.0.1 docs

---------

Co-authored-by: Kasurus <38571075+Kasurus@users.noreply.github.com>
Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
Co-authored-by: Chris Mc <christopherm@jfrog.com>
Co-authored-by: Caijinglong <cjl_spy@163.com>
memsharded pushed a commit that referenced this pull request Mar 29, 2023
@ChrisThrasher @czoido
@Kasurus @AbrilRBS @CaiJingLong
Fix typo (#3134)
ae7c1a0 
* Fix command conan remote (#3031)

* Fix conan remote add -h content

* Fix indentation

* Change 'optional arguments' to 'options'

Makes it identical to the actual command line output.

* Add info on .conanignore (#3036)

* Add info on .conanignore

* Add missing point

* Update conan config install documentation (#3035)

* Fix conan remote auth help typo (#3039)

* Fix conan remote auth help typo

* Fix whitespace issue

* fix typo for import syntax (#3024)

* Update tools.rst (#3047)

Fix typo

* Change documentation from conan-io/conan#13211 (#3046)

* add docs (#3049)

* remove from docs (#3050)

* Fix typo

---------

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Kasurus <38571075+Kasurus@users.noreply.github.com>
Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
Co-authored-by: Chris Mc <christopherm@jfrog.com>
Co-authored-by: Caijinglong <cjl_spy@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2
Development

Successfully merging this pull request may close these issues.
4 participants
@Kasurus @CLAassistant @AbrilRBS @memsharded