Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document options managed automatically #3296

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Jul 12, 2023

@@ -48,3 +48,109 @@ The public documented interface (besides the defined one in :ref:`the package_in
- ``CppInfo(conanfile)``: Constructor. Receives a ``conanfile`` as argument, typically ``self``
- ``aggregated_components()``: return a new ``CppInfo`` object resulting from the aggregation of all the components
- ``merge(other_cppinfo: CppInfo)``: modifies the current ``CppInfo`` object, updating it with the information of the parameter ``other_cppinfo``, allowing to aggregate information from multiple dependencies.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not rename this file yet to avoid disturbing the diff

@czoido czoido changed the base branch from release/2.0 to develop2 July 12, 2023 13:22
@czoido czoido changed the base branch from develop2 to release/2.0 July 12, 2023 13:23
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great explanation @danimtb ! 👏 Only a few wording comments (we can discuss them for sure).

reference/conanfile/methods/config_options.rst Outdated Show resolved Hide resolved
reference/conanfile/methods/config_options.rst Outdated Show resolved Hide resolved
reference/conanfile/methods/config_options.rst Outdated Show resolved Hide resolved
reference/conanfile/methods/config_options.rst Outdated Show resolved Hide resolved
reference/conanfile/methods/configure.rst Outdated Show resolved Hide resolved
reference/tools/cpp_info.rst Outdated Show resolved Hide resolved
reference/tools/cpp_info.rst Outdated Show resolved Hide resolved
reference/tools/cpp_info.rst Outdated Show resolved Hide resolved
reference/tools/cpp_info.rst Outdated Show resolved Hide resolved
reference/tools/cpp_info.rst Outdated Show resolved Hide resolved
@danimtb danimtb changed the base branch from release/2.0 to develop2 July 13, 2023 08:39
@danimtb danimtb changed the base branch from develop2 to release/2.0 July 13, 2023 08:40
Apply suggestions from code review

Update reference/tools/cpp_info.rst

Update reference/tools/cpp_info.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Update reference/tools/cpp_info.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Update reference/tools/cpp_info.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Update reference/tools/cpp_info.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Update reference/tools/cpp_info.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Update reference/conanfile/methods/configure.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Update reference/conanfile/methods/config_options.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Update reference/conanfile/methods/config_options.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Update reference/conanfile/methods/config_options.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Update reference/conanfile/methods/configure.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Update reference/conanfile/methods/package_id.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Update reference/conanfile/methods/package_id.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

Update reference/tools/cpp_info.rst

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
@danimtb danimtb force-pushed the feature/manage_options branch from b2fced4 to cd7dfad Compare July 13, 2023 08:50
@danimtb danimtb changed the base branch from release/2.0 to develop2 July 13, 2023 08:51
@czoido czoido removed the request for review from AbrilRBS July 13, 2023 09:02
@czoido czoido merged commit 7efd839 into conan-io:develop2 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants