check for patches not referenced in conandata.yml #536

ericLemanissier · 2024-04-24T07:30:18Z

reimplement part of https://github.com/ericLemanissier/conan-center-lint-patches/blob/main/lint_patches.py
results are tracked in conan-io/conan-center-index#21146

ericLemanissier · 2024-04-24T07:35:17Z

last PRs fixing offenders:

reimplement part of https://github.com/ericLemanissier/conan-center-lint-patches/blob/main/lint_patches.py results are tracked in conan-io/conan-center-index#21146

ericLemanissier · 2024-04-24T08:55:44Z

I tried all recipes in CCI with

#!/bin/bash
conan config set hooks.conan-center
export CONAN_HOOK_ERROR_LEVEL=40
last_package_folder=""
find . -mindepth 1 -maxdepth 1 -type d  -printf '%f\n' | while read -r package; do
    yq '.versions | to_entries[] | "\(.key) \(.value.folder)"' "$package/config.yml" -r | while IFS= read -r line; do
        IFS=' ' read -r version folder <<< "$line"
        if [ "$package/$folder" != "$last_package_folder" ]; then
            last_package_folder="$package/$folder"
            conan export $package/$folder "$package/$version@"
        fi
    done
done

Results:

freetype/all/ fixed by freetype: remove dangling patch conan-center-index#23748

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/2.13.0-0001-fix-fallthrough.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

opencolorio/all/ fixed by opencolorio: remove dangling patches conan-center-index#23750

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/1.1.1.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES) 
[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/fix-cmake-source-dir-and-targets.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES) 
[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/pstring.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES) 
[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/strlen.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

co/all/ is deprecated

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/002-fix-event-destruct.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

zlib/all/ fixed by zlib: remove dangling patch conan-center-index#23751

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/1.3/0002-gzguts-xcode12-compile-fix.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

folly/all/ is not ready for conan 2

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/0021-typedef-clockid.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

libvault/all/ fixed by libvault: remove dangling patches conan-center-index#23739

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/0.48.0-0001-fix-cmake.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES) 
[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/0.51.0-0001-fix-cmake.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES) 
[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/0.52.0-0001-fix-cmake.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

ignition-tools/all/ is not ready for conan 2

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/0001-ign-tools-1.0.0-cmake-fixes.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES) 
[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/0002-ign-tools-1.2.0-cmake-fixes.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

fmt/all/ fixed by fmt: remove dangling patch conan-center-index#23747

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/fix-install-6.0.0.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES) 
[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/fix-mingw-msvc2015-export-assert-fail-6.1.0.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

diligent-tools/all/ is not ready for conan 2

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/0003-fix-diligent-core-include-paths.diff (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

diligentgraphics-spirv-tools/all/ is deprecated

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/support-SPV_KHR_fragment_shading_rate.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

luajit/all/ fixed by luajit: remove dangling patch conan-center-index#23749

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch files is not referenced in conandata.yml: patches/20230104-0001-remove-mac-deploy.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

Hooks errors not related to this change

(it looks like conan-io/conan-center-index#20516 (comment) does not work any more):

ogre/1.x

[HOOK - conan-center.py] pre_export(): ERROR: [REQUIREMENT OVERRIDE PARAMETER (KB-H075)] self.requires('package/version', override=True) is forbidden, do not force override parameter. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H075-REQUIREMENT-OVERRIDE-PARAMETER)

mdnsresponder/all/:

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] The versions {'878.200.35-opt'} are in 'patches' but not in 'sources'. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

uilianries · 2024-04-24T14:15:26Z

Nice! I see it as a good improvement, but I would prefer fixing all recipes first, because it's classified as error. Otherwise, any non-related PR would be broken.

ericLemanissier · 2024-04-24T14:51:18Z

@uilianries done, I integrated the information in my message above

hooks/conan-center.py

ericLemanissier · 2024-04-25T09:01:01Z

As you wanted, all the patches are now grouped on the same line instead of one line per patch.
Here are two examples of logs generated:

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch file(s) are/is not referenced in conandata.yml: patches/2.13.0-0001-fix-fallthrough.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

[HOOK - conan-center.py] pre_export(): ERROR: [NO DANGLING PATCHES (KB-H078)] Following patch file(s) are/is not referenced in conandata.yml: patches/1.1.1.patch, patches/fix-cmake-source-dir-and-targets.patch, patches/pstring.patch, patches/strlen.patch (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H078-NO-DANGLING-PATCHES)

I don't think it's more readable, but as you want

ericLemanissier · 2024-04-26T14:48:30Z

@uilianries all the fixes have been merged. The only offenders remaining are either deprecated, or not compatible with conan 2.

jcar87

Pending discussion with the team.
(likely to be merged, this is a good change, thanks @ericLemanissier )

ericLemanissier · 2024-05-03T09:40:52Z

@jcar87 What's the opinion of the team regarding this change ?

ericLemanissier · 2024-05-16T08:41:42Z

@jcar87 @uilianries can we please have an update on the status of this PR ?

ericLemanissier · 2024-05-30T11:27:09Z

conan-io/conan-center-index#24165

check for patches not referenced in conandata.yml

85dba7f

reimplement part of https://github.com/ericLemanissier/conan-center-lint-patches/blob/main/lint_patches.py results are tracked in conan-io/conan-center-index#21146

ericLemanissier force-pushed the patch-2 branch from 9763f2e to 85dba7f Compare April 24, 2024 08:16

This comment was marked as outdated.

Sign in to view

Croydon reviewed Apr 24, 2024

View reviewed changes

hooks/conan-center.py Outdated Show resolved Hide resolved

ericLemanissier added 2 commits April 24, 2024 23:34

typo

ceacaca

group reports

2f1a8ec

ericLemanissier force-pushed the patch-2 branch from f919b5a to 2f1a8ec Compare April 25, 2024 08:52

ericLemanissier requested a review from uilianries April 25, 2024 12:28

jcar87 requested changes Apr 26, 2024

View reviewed changes

ericLemanissier requested a review from jcar87 May 21, 2024 08:03

ericLemanissier closed this May 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

check for patches not referenced in conandata.yml #536

check for patches not referenced in conandata.yml #536

ericLemanissier commented Apr 24, 2024

ericLemanissier commented Apr 24, 2024

ericLemanissier commented Apr 24, 2024 •

edited

Loading

uilianries commented Apr 24, 2024

This comment was marked as outdated.

ericLemanissier commented Apr 24, 2024 •

edited

Loading

ericLemanissier commented Apr 25, 2024

ericLemanissier commented Apr 26, 2024

jcar87 left a comment •

edited

Loading

ericLemanissier commented May 3, 2024

ericLemanissier commented May 16, 2024

ericLemanissier commented May 30, 2024

check for patches not referenced in conandata.yml #536

check for patches not referenced in conandata.yml #536

Conversation

ericLemanissier commented Apr 24, 2024

ericLemanissier commented Apr 24, 2024

ericLemanissier commented Apr 24, 2024 • edited Loading

Results:

Hooks errors not related to this change

uilianries commented Apr 24, 2024

This comment was marked as outdated.

ericLemanissier commented Apr 24, 2024 • edited Loading

ericLemanissier commented Apr 25, 2024

ericLemanissier commented Apr 26, 2024

jcar87 left a comment • edited Loading

Choose a reason for hiding this comment

ericLemanissier commented May 3, 2024

ericLemanissier commented May 16, 2024

ericLemanissier commented May 30, 2024

ericLemanissier commented Apr 24, 2024 •

edited

Loading

ericLemanissier commented Apr 24, 2024 •

edited

Loading

jcar87 left a comment •

edited

Loading