Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a player leaves the game, his vote is still counted #132

Closed
roosi-ann opened this issue Mar 9, 2021 · 0 comments
Closed

If a player leaves the game, his vote is still counted #132

roosi-ann opened this issue Mar 9, 2021 · 0 comments
Milestone
First release

Comments

@roosi-ann
Copy link
Contributor

roosi-ann commented Mar 9, 2021 •
edited
Loading

If a player votes during the first round and then disappears, his vote is still counted during next rounds. The team can stay stuck on the same question if player does not rejoin and change answer and everyone else votes differently.

Reproduce: Vote 0 with P1, others vote 3. Leave game with P1. Others still vote 3, but cannot progress to the next question since P1 voted 0.

If problem is solved for dropout players with stability fixes, leave this for after release.
@roosi-ann roosi-ann added this to the First release milestone Mar 24, 2021
@roosi-ann roosi-ann assigned ghost Mar 26, 2021
ghost pushed a commit that referenced this issue Mar 30, 2021
SA-#132 Added isActive to check if player has left
a52380e
ghost pushed a commit that referenced this issue Apr 19, 2021
SA-#132 Gone player vote now is not deleted by the host. Game checks …
df28934 
…if player has left using timer
ghost pushed a commit that referenced this issue Apr 20, 2021
#132 Declared timer
44fc61f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
First release
Development

No branches or pull requests
2 participants
@roosi-ann @user950520