Added multi-language support via i18n #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevPhilB
reviewed
Jan 20, 2020
vue/src/router/index.js
Outdated
| beforeEnter(to,from,next){ | ||
| const lang = to.params.lang; | ||
| //redirect to empty /en page | ||
| //TODO replace '/en' with usefull language info or 404 page |
There was a problem hiding this comment.
Remove TODO before creating pull requests
DevPhilB
reviewed
Jan 20, 2020
vue/src/router/index.js
Outdated
| mode: 'history', | ||
| base: process.env.BASE_URL, | ||
| routes: [{ | ||
| //check for language prefix (i.e /en/ or /de/). Default to /en/ if no valid prefix was found |
There was a problem hiding this comment.
No language prefixes needed
We use local variable (kazupon/vue-i18n#2)
DevPhilB
suggested changes
Jan 20, 2020
There was a problem hiding this comment.
Good approach, we have decided to use a reactive language state instead of .../de/, .../en/.
Please check this issue out: kazupon/vue-i18n#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(eg. "midnightboard/de/about")
Using localized i18n strings
Localized Strings have to be added to
vue/src/lang/translations/en.jsonand/de.jsonrespectively.To reference a localized string, use the $t parameter, eg.
<p> {{ $t('helloWorld' ) }} </p>