This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
Prevent nesting of volumes with overlay driver from exceeding kernel limit
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this just makes it easier to run with `fly execute`; it'll be overridden with the proper image in the pipeline Signed-off-by: Alex Suraci <asuraci@vmware.com> Co-authored-by: Vikram Yadav <vyadav@vmware.com>
Signed-off-by: Alex Suraci <asuraci@vmware.com> Co-authored-by: Vikram Yadav <vyadav@vmware.com>
when creating a copy of a copy, instead of nesting, copy the parent's upper dir into the child's upper dir and then set the child's parent to the grandparent. this keeps the depth from growing unbounded, which is important considering the kernel has a hardcoded depth limit of 2. the trade-off is that we'll copy the upper directory contents in this situation, but hopefully the upper directory will usually be small enough for this to not matter much. (in any case, there doesn't seem to be a better choice. sadly.) concourse/concourse#5799 Signed-off-by: Alex Suraci <asuraci@vmware.com> Co-authored-by: Vikram Yadav <vyadav@vmware.com>
use filesystem types, since the Overlay driver cares a lot more about the handle and parent relationship subsequent commit will redo the mount recovery so that we don't need the layerDirOld/workDirOld methods Signed-off-by: Alex Suraci <asuraci@vmware.com> Co-authored-by: Vikram Yadav <vyadav@vmware.com>
now that we can trust that volumes only ever have a parent (and not a grandparent), recovery can be done in just two passes. adds a Recover(Filesystem) method to the Driver interface. Signed-off-by: Alex Suraci <asuraci@vmware.com> Co-authored-by: Vikram Yadav <vyadav@vmware.com>
|
Based on the changes to Overlay recover, the workers would need to be recreated to ensure the recover method works |
|
Baggage claim unit test are failing |
|
@xtreme-sameer-vohra They seem to be passing in CI? 🤔 That's the error you should see without the fix. How are you running the tests? |
hmm interesting, I ran it on ci using and the error is from creating the first child volume. It looks like it didn't get far enough to try to created the doubly nested one. |
|
@xtreme-sameer-vohra 👻 spooky 👻 I re-ran the build a few times to be sure, and they passed. Would be nice to know why that happened, but I guess I'll merge anyway. 🤷♂️ |
vito
changed the title
overlay driver from exceeding kernel limit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.