This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
Change device regex if testing on windows #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows network device names are very different from unix systems. On unix you'll get a list like this: ``` lo0 en0 ... ``` On Windows you'll get this: ``` Ethernet 4 Local Area Connection* 2 Local Area Connection* 12 Wi-Fi 5 Bluetooth Network Connection 2 Loopback Pseudo-Interface 1 vEthernet (Default Switch) ``` You can't even use a simple regex like `lo` that the test was using because you could end up matching against the "Local Area..." devices instead for the test (this may be what you want in the real world though). Signed-off-by: Taylor Silva <tsilva@pivotal.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to release a new version of baggageclaim, this was only a problem with the test on windows.
The change is on line 46-48
The file got formatted and I decided to keep it in the commit.
Windows network device names are very different from unix systems.
On unix you'll get a list like this:
On Windows you'll get this:
You can't even use a simple regex like
lothat the test was usingbecause you could end up matching against the "Local Area..." devices
instead for the test (this may be what you want in the real world
though).