Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource type check interval #8381

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Add resource type check interval #8381

merged 4 commits into from
Apr 4, 2024

Conversation

Caprowni
Copy link
Contributor

Changes proposed by this PR

Closes #8264

  • Added a configuration option for resource types as opposed to just a generic check with covers resources, resource types & prototypes - just like the issue describes.

Release Note

  • This adds an option for a user to configure resource types to be checked every X time at a global level as opposed to setting check_every on each resource type.

@Caprowni Caprowni requested a review from a team as a code owner May 27, 2022 15:30
@Caprowni Caprowni self-assigned this May 27, 2022
@Caprowni Caprowni mentioned this pull request May 27, 2022
Open
6 tasks
@Caprowni
Copy link
Contributor Author

All the tests pass local and it seems like it wasn't even a test case that failed here so not sure what's up 🤷‍♂️

@xtremerui
Copy link
Contributor

@Caprowni it is just the flaky of CI

@xtremerui xtremerui added this to the v7.9.0 milestone Jun 1, 2022
@Caprowni Caprowni force-pushed the master branch 2 times, most recently from 5c83591 to 3f80936 Compare July 5, 2022 10:23
@Caprowni Caprowni changed the title Add resource type check interval Add resource type check interval[WIP] Jul 5, 2022
@Caprowni Caprowni changed the title Add resource type check interval[WIP] Add resource type check interval Jul 10, 2022
@Caprowni
Add resource type check interval
9afd045 
Signed-off-by: caprowni <liamcaproni@gmail.com>
@Caprowni Caprowni requested a review from xtremerui July 10, 2022 14:46
xtremerui
xtremerui reviewed Jul 11, 2022
View reviewed changes
atc/db/db_suite_test.go Outdated Show resolved Hide resolved
@xtremerui
Copy link
Contributor

@Caprowni we are close to ship v7.9, if you are not working on this PR ATM, i will remove it from current release.

@Caprowni
Copy link
Contributor Author

@xtremerui Sorry, I haven't been able to work on this up until now, will dust off where I got to and finish up the tests. 😓

@Caprowni
Updating appropriate test checks and check time
d41e2fe 
Signed-off-by: caprowni <liamcaproni@gmail.com>
@taylorsilva taylorsilva modified the milestones: v7.9.0, v7.12.0 Apr 4, 2024
taylorsilva
taylorsilva approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@taylorsilva taylorsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylorsilva taylorsilva merged commit 864bc19 into concourse:master Apr 4, 2024
4 checks passed
@xtremerui xtremerui mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchaoli evanchaoli evanchaoli left review comments

@xtremerui xtremerui xtremerui left review comments

@taylorsilva taylorsilva taylorsilva approved these changes

Assignees

@xtremerui xtremerui

@Caprowni Caprowni

Labels
enhancement
Projects
None yet
Milestone
v7.12.0
Development

Successfully merging this pull request may close these issues.

Add a global checking interval for resource types
4 participants
@Caprowni @xtremerui @taylorsilva @evanchaoli