workaround checkout-error for nested shallow submodules #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a nested submodule is configured to be "shallow", referencing a commit that is not reachable from the respective repository's HEAD (typically the default branch, if e.g. hosted on GitHub), will result in an error when checking out the submodule (git submodule update..). Workaround this by always setting `--no-recommend-shallow`, which lets git ignore this setting.
|
My knowledge with git shallow clone is limited. Would adding this flag cause users cloning more data than they want (if their submodules is meant to be shallow)? |
mshuaiebsabri
approved these changes
Jun 10, 2022
xtremerui
force-pushed
the
master
branch
2 times, most recently
from
0e21d41
to
5f77e61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a nested submodule is configured to be "shallow", referencing a
commit that is not reachable from the respective repository's HEAD
(typically the default branch, if e.g. hosted on GitHub), will result in
an error when checking out the submodule (git submodule update..).
Workaround this by always setting
--no-recommend-shallow, whichlets git ignore this setting.
For a "real-world" example, see: google/docsy#755 (I also commented there)