feat: support arbitrary prerelease strings #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the user to opt into checking for prefixes other than the default alpha/beta/rc. Opting in additionally allows for prereleases containing '-' delimeters as allowed by Semver 2.0.0. Signed-off-by: Conor Nosal <cnosal@vmware.com>
Match arbitrary tags. Takes precendence over pre_releases. Signed-off-by: Conor Nosal <cnosal@vmware.com>
cjnosal
force-pushed
the
prereleaseprefixes
branch
from
35d5346
to
63f82f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation assumes the prerelease portion of a semver tag is alpha/beta/rc optionally followed by a variant, with no other
-characters. This MR adds two new source params to broaden support for arbitrary semver tags while maintaining backwards compatibility:source.pre_release_prefixeslets the user append to the default prefixes of alpha/beta/rc (e.g. "dev" or "build")without otherwise changing the current pre_releases behaviour. Setting pre_release_prefixes skips the "pre-release contains-" check.source.tag_regexlets users match against arbitrary expressions.source.pre_releasesis ignored when a regex is set. semver_constraint and variant can still be used in combination with tag_regex.fix #307