fix flakey check tests #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point when adding these tests, we forgot that maps in Go do not guarantee that the order items are added is the order they'll appear in when iterating over the map: https://go.dev/blog/maps (see very last section) This commit changes the `Tags` input into a slice, which does have a guaranteed order when iterating over. Signed-off-by: Taylor Silva <dev@taydev.net>
|
thank you @taylorsilva ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point when adding these tests, we forgot that maps in Go do not guarantee that the order items are added is the order they'll appear in when iterating over the map: https://go.dev/blog/maps (see very last section)
This commit changes the
Tagsinput into a slice, which does have a guaranteed order when iterating over.Ran the tests locally many times and am no longer getting seeing any flakiness.