Adds support for ECR auth when running concourse on an EC2 instance #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…C2 instance Signed-off-by: David Neale <neale.dj@gmail.com>
nealedj
changed the title
|
+1 |
|
Sorry but I can't merge this because it breaks the security model of sharing version history. More context here: concourse/concourse#3023 tl;dr: Resources are identified entirely by their configuration. If credentials are not in the configuration, the version history will become 'shared' to people who shouldn't have access. Future plans for supporting ECR auth are described in #3023. Thanks for the PR though. 🙂 You're welcome to use a fork until proper support is implemented, I just don't want to adopt this pattern in our core resource types. |
|
This breaks our flow as well. The docker-image breaks in 6.3.0 and I don't want to be adding credentials in my pipelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run concourse on an EC2 instance which has an instance role which already allows it ECR permissions.
The existing implementation would have forced me to some static credentials available within concourse and I'd rather not if possible as credentials are already available from the metadata API.
There's a similar PR open on the s3-resource: concourse/s3-resource#115