-
Notifications
You must be signed in to change notification settings - Fork 166
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Problems - `AdjustNumberProperty` and `UpdatePropIfExists` command aren't used - `deleteValuesAtPath` and `applyValuesAtPath` are defined in command runners, but are actually widely used helpers ## Fix - Delete `AdjustNumberProperty` and `UpdatePropIfExists` - Move `deleteValuesAtPath` and `applyValuesAtPath` into a dedicated utils file **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode --------- Co-authored-by: Balazs Bajorics <2226774+balazsbajorics@users.noreply.github.com>
- Loading branch information
1 parent
fd3e0ad
commit 4c0ed00
Showing
18 changed files
with
100 additions
and
522 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143 changes: 0 additions & 143 deletions
143
editor/src/components/canvas/commands/adjust-number-command.spec.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.