Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework SubduedGridGapControl #6564

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

seanparsons
Copy link
Contributor

Problem:
When you interact with the grid gap in the inspector, we show a pink outline on the canvas. Make the pink SubduedGridGapControl use GridPaddingOutlineForDimension instead of the current code which still relies on gridGapControlBoundsFromMetadata.

Fix:
Changed out the main rendering content of SubduedGridGapControl to use GridPaddingOutlineForDimension and added an option so that we can supply an alternative colour for the outlines.

Commit Details:

  • Removed a lot of the contents of SubduedGridGapControl and replace the main contents of the rendering with GridPaddingOutlineForDimension.
  • Added draggedOutlineColor to GridPaddingOutlineForDimension and GridRowHighlight.
  • Removed gridGapControlBoundsFromMetadata.

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

- Removed a lot of the contents of `SubduedGridGapControl` and replace the
  main contents of the rendering with `GridPaddingOutlineForDimension`.
- Added `draggedOutlineColor` to `GridPaddingOutlineForDimension` and
  `GridRowHighlight`.
- Removed `gridGapControlBoundsFromMetadata`.
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Try me

Copy link

relativeci bot commented Oct 18, 2024

#14865 Bundle Size — 57.98MiB (~-0.01%).

ee4615a(current) vs 916e8b9 master#14861(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#14865
     Baseline
#14861
Improvement  Initial JS 40.96MiB(-0.01%) 40.97MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18% 17.88%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4153 4153
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.33% 27.33%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#14865
     Baseline
#14861
Improvement  JS 57.97MiB (~-0.01%) 57.97MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch refactor/subdued-grid-gap-contro...Project dashboard


Generated by RelativeCIDocumentationReport issue

@seanparsons seanparsons merged commit a53ecb5 into master Oct 18, 2024
16 checks passed
@seanparsons seanparsons deleted the refactor/subdued-grid-gap-control branch October 18, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants