Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When you interact with the grid gap in the inspector, we show a pink outline on the canvas. Make the pink
SubduedGridGapControl
useGridPaddingOutlineForDimension
instead of the current code which still relies ongridGapControlBoundsFromMetadata
.Fix:
Changed out the main rendering content of
SubduedGridGapControl
to useGridPaddingOutlineForDimension
and added an option so that we can supply an alternative colour for the outlines.Commit Details:
SubduedGridGapControl
and replace the main contents of the rendering withGridPaddingOutlineForDimension
.draggedOutlineColor
toGridPaddingOutlineForDimension
andGridRowHighlight
.gridGapControlBoundsFromMetadata
.Manual Tests:
I hereby swear that: