return ValueList from separate method to be able to inject custom values

[Remo]

By extracting this part of the method we can easily override the result of ValueList in our page theme controller. This would offer the possibility to add custom values from our PHP code.

Creating a variable my-color would work with this:

    public function getThemeCustomStyleObjectValues()
    {
        $valueList = parent::getThemeCustomStyleObjectValues();

        $myColor = new \Concrete\Core\StyleCustomizer\Style\Value\ColorValue('my');
        $myColor->setAlpha(0.5);
        $myColor->setRed(111);
        $myColor->setBlue(222);
        $myColor->setGreen(33);

        $valueList->addValue($myColor);

        return $valueList;
    }

[myconcretelab]

This seems to be a great and very compatible way with future improvement.
The only limitation is ta have four lines to change a color.
I would be happy to see this merged !

[Remo]

yeah, you'd need more code, but using LESS is wrong as we might have/want to support SCSS, PostCSS in the future in which case this should be the better approach. We could create more constructors to be able to specify the colour values in one line. That doesn't concern me much at this point.

[myconcretelab]

I completely agree ! You don't know how i'm happy ! Thank you.
Read that SASS will be integrated is another great news !!

[myconcretelab]

I'm sorry i'm a bit new to Github but i don't understand why this merge is not in the new 5.7.5.3 ?

[Remo]

because it was only merged into develop and not into release/5.7.5.3
Check this: https://github.com/concrete5/concrete5/tree/release/5.7.5.3

This branch is 230 commits behind develop.