Skip to content
This repository has been archived by the owner on Sep 29, 2022. It is now read-only.

Enable MINC support in simpleitk build #700

Closed
wants to merge 1 commit into from

Conversation

gdevenyi
Copy link

@gdevenyi gdevenyi commented Sep 9, 2016

This PR depends on the merging of SimpleITK/SimpleITK#67 so that the options specified for SimpleITK are passed via the SuperBuild to ITK.

@blowekamp
Copy link
Contributor

blowekamp commented Sep 12, 2016

MINC is a popular image format and this is a useful feature to be able to enable for SimpleITK. However this ITK module has not been enable by default in ITK because there are a number of Valgrind memory defects that have not been addressed. We which to distribute a stable and reliable package,

Could this be turned into an option feature[1]? ( or the issues in ITK addressed? )

Also here is the update to the latest SimpleITK release #701

Thanks!

[1] http://conda.pydata.org/docs/building/meta-yaml.html#id1

@gdevenyi
Copy link
Author

Hi @blowekamp,

Can you point me at the valgrind issues so I can inform the MINC maintainers of this?

As for converting to an option, that's doable, I'll have to figure that out.

Are you proposing I rebase against #701 ?

@blowekamp
Copy link
Contributor

With the current ITK master, many of the tests are not even passing:

https://open.cdash.org/viewTest.php?onlyfailed&buildid=4545427

I only checked that after running valgrind:

https://open.cdash.org/viewDynamicAnalysis.php?buildid=4545685

@gdevenyi
Copy link
Author

Thanks @blowekamp,

I've opened up an issue with libminc here BIC-MNI/libminc#75

@gdevenyi
Copy link
Author

Defaults on in ITK 5.0 now.

@gdevenyi gdevenyi closed this Dec 10, 2018
@blowekamp
Copy link
Contributor

MINC was include in the SImpleITK 1.1 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants