Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADIOS2 v2.9+ Uses Blosc2 #84

Merged
merged 4 commits into from
Nov 10, 2023
Merged

ADIOS2 v2.9+ Uses Blosc2 #84

merged 4 commits into from
Nov 10, 2023

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Nov 9, 2023

Update the compressor to use C-Blosc2.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Update the compressor to use C-Blosc2.
@ax3l ax3l added the bug Something isn't working label Nov 9, 2023
@ax3l
Copy link
Member Author

ax3l commented Nov 9, 2023

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ax3l
Copy link
Member Author

ax3l commented Nov 10, 2023

Looks like the same bug as ornladios/ADIOS2#3903

Will manually remove FindBlosc2.cmake

@ax3l ax3l merged commit 527f9e6 into conda-forge:main Nov 10, 2023
52 of 53 checks passed
@ax3l ax3l deleted the fix-blosc2 branch November 10, 2023 18:18
@vicentebolea
Copy link
Contributor

@ax3l this is very odd, 2.9.2 contains the change that prefers the config cmake file rather than the module (FindBlosc) as shown here https://github.com/ornladios/ADIOS2/blob/v2.9.2/cmake/DetectOptions.cmake#L73. I think that there is no need to add the patched that you added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants