-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 4.2.0rc0 #121
Prepare 4.2.0rc0 #121
Conversation
Fix version
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.11.23.15.09.04
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/arcticdb-feedstock/actions/runs/6981697583. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.11.23.15.09.04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @G-D-Petrov.
Here are a few suggestions of adaptations regarding recent changes on the feedstock and upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to port the recent changes made in https://github.com/conda-forge/arcticdb-feedstock/pull/119/files#diff-ff61408cdc05bc9667deeadb55e4aaceb1371972076b6bf6934f9008920f2bd2R9-R22.
Need not be addressed: ideally we should couple versions of dependencies together to have two specification:
- the relaxed (i.e. pin-less) specification of libraries as on
main
- the specific specification of libraries of
libevent-2.1.10
I believe this is doable with zip_keys
as follows:
- "11.0" # [osx and x86_64]
MACOSX_DEPLOYMENT_TARGET: # [osx and x86_64]
- "11.0" # [osx and x86_64]
-libevent:
- - "2.1.10"
- - "2.1.12"
lmdb:
- 0.9.22
folly:
# This version of folly is used to make the build usable by more environments
- - "2023.09.25.00"
+ - "2023.09.25.00"
+
+# Coupling dependencies specification together.
+# The first lines come from the specifications of the `libevent-2.1.10` branch.
+# The second lines come from the specifications of the `main` branch.
+# See: https://docs.conda.io/projects/conda-build/en/stable/resources/variants.html#coupling-keys
+libevent:
+ - "2.1.10"
+ - "2.1.12"
+aws_sdk_cpp:
+ - "1.10.57"
+ - "*"
+azure_core_cpp:
+ - "1.10.2"
+ - "*"
+azure_identity_cpp:
+ - "1.5.1"
+ - "*"
+azure_storage_blobs_cpp:
+ - "12.9.0"
+ - "*"
+zip_keys:
+ - libevent
+ - aws_sdk_cpp
+ - azure_core_cpp
+ - azure_identity_cpp
+ - azure_storage_blobs_cpp
channel_targets:
- conda-forge arcticdb_rc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to man-group/ArcticDB#1027 and to https://github.com/man-group/ArcticDB/pull/1005/files, the following python dependencies can be dropped:
- pymongo
- grpcio-tools
- xxhash
- six
- decorator
- prometheus_client
Unrelated but dataclasses
which is needed for python < 3.8 can also be dropped since conda-forge only builds for python>=3.8.
Fix version
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)