Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin numpy >=2.1 and python >=3.10 #14

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

kmuehlbauer
Copy link
Contributor

@kmuehlbauer kmuehlbauer commented Nov 8, 2024

closes #13

Not sure how to fix the _0 build, but maybe this is just a change in the metadata of the package.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@kmuehlbauer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • noarch: python recipes should almost always follow the syntax in our documentation. For the host section of the recipe, you should almost always use python {{ python_min }} for the python entry. For the run section of the recipe, you should almost always use python >={{ python_min }} for the python entry. For the test.requires section of the recipe, you should almost always use python {{ python_min }} for the python entry. You may need to override the python_min variable in the conda_build_config.yaml/variants.yaml if the package requires a newer Python version than the currently supported minimum version on conda-forge.
  • PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11737801592.

@kmuehlbauer
Copy link
Contributor Author

@conda-forge/array-api-strict @conda-forge/core Please check this PR, #13 will affect any automated CI where numpy <2.1 is installed.

@xhochy
Copy link
Member

xhochy commented Nov 8, 2024

What's the reason to ping core here? Please keep it with feedstock maintainers and only ping core if they don't respond.

@kmuehlbauer
Copy link
Contributor Author

Thanks @xhochy for responding, and sorry for pinging core. This affects my day work, but I'll work around for now. I'll wait for the maintainers to respond.

Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmuehlbauer! The changes here are correct, however we also need python >=3.10 rather than >=3.9 now. I'll add that as well.

recipe/meta.yaml Outdated Show resolved Hide resolved
@rgommers rgommers changed the title pin numpy >=2.1 pin numpy >=2.1 and python >=3.10 Nov 8, 2024
@rgommers rgommers merged commit e361409 into conda-forge:main Nov 8, 2024
4 checks passed
@kmuehlbauer
Copy link
Contributor Author

Thanks for taking care that quickly @rgommers!

@kmuehlbauer kmuehlbauer deleted the kmuehlbauer-patch-1 branch November 8, 2024 09:53
@jakirkham
Copy link
Member

These version constraint changes could be picked automatically during version updates if Grayskull were enabled here

More details on how to do this in issue: #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.1.2 breaks for environments with numpy < 2.1
5 participants